Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Updates var usage to let #321

Merged
merged 1 commit into from
Apr 9, 2019
Merged

chore: Updates var usage to let #321

merged 1 commit into from
Apr 9, 2019

Conversation

jbottigliero
Copy link
Member

  • No longer uses standard directly, instead uses the recommmend manual configuration to allow for the addition of the no-var eslint rule.
  • Uses eslint . --fix after the configuration update to swap var usage to let

see #276

chore: Updates var usage to let
80cec38 
- No longer uses `standard` directly, instead uses the [recommmend manual configuration](https://github.com/standard/eslint-config-standard) to allow for the addition of the [`no-var`](https://eslint.org/docs/rules/no-var) eslint rule.
- Uses `eslint . --fix` after the configuration update to swap `var` usage to `let`

see conventional-changelog#276
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 80cec38 on jbottigliero:eslint-no-var into aad6a61 on conventional-changelog:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 80cec38 on jbottigliero:eslint-no-var into aad6a61 on conventional-changelog:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 80cec38 on jbottigliero:eslint-no-var into aad6a61 on conventional-changelog:master.

@jbottigliero
Copy link
Member Author

This does move away from using the standard package directly, but it more closely resembles the eslint setup in conventional-changelog (with the addition of the no-var rule).

It looks like work might be picking up soon to get the rule introduced to standard, here. But this configuration would allow use to move forward and have one less --fix diff should we revert back to using standard directly.

stevemao
stevemao approved these changes Mar 30, 2019
View reviewed changes
Copy link
Member

@stevemao stevemao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@bcoe bcoe merged commit 71e8a04 into conventional-changelog:master Apr 9, 2019
@MiniGod MiniGod mentioned this pull request Apr 17, 2019
Merged
jbottigliero pushed a commit that referenced this pull request Apr 27, 2019
test: use const based on new eslint rules
32855f4 
This was caused by tests in #320 using `var` and being merged into the trunk (as-is) just before the new eslint rules (#321)
@jbottigliero jbottigliero mentioned this pull request Apr 27, 2019
Merged
bcoe pushed a commit that referenced this pull request May 5, 2019
@bcoe
test: use const based on new eslint rules
67f2f15 
This was caused by tests in #320 using `var` and being merged into the trunk (as-is) just before the new eslint rules (#321)
bcoe pushed a commit that referenced this pull request May 5, 2019
@bcoe
test: use const based on new eslint rules
5a46b5a 
This was caused by tests in #320 using `var` and being merged into the trunk (as-is) just before the new eslint rules (#321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemao stevemao stevemao approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbottigliero @coveralls @stevemao @bcoe