Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-nx-scopes): include file extension in nx imports #3979

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix(config-nx-scopes): include file extension in nx imports #3979

merged 1 commit into from
Mar 16, 2024

Conversation

timonmasberg
Copy link
Contributor

As the package is now pure ESM, we need to add the file extension to imports from nx as they are not coming from a package.json export field (https://nodejs.org/api/esm.html#esm_mandatory_file_extension).

Description

By adding the file extensions, the modules get resolved again.

Motivation and Context

Fixes #3978

How Has This Been Tested?

Verified on https://github.com/timonmasberg/commitlint-nx-bug, which is a reporduction for the bug.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@escapedcat escapedcat merged commit 583250b into conventional-changelog:master Mar 16, 2024
7 checks passed
@escapedcat
Copy link
Member

Will publish a release after some other issues got feedback

@escapedcat
Copy link
Member

Also, thanks!

@escapedcat
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: @commitlint/config-nx-scopes not working for nx since version v19
3 participants