Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): added @commitlint/config-nx-scopes for nx monorepos #3913

Merged
merged 3 commits into from
Apr 19, 2024
Merged

feat(container): added @commitlint/config-nx-scopes for nx monorepos #3913

merged 3 commits into from
Apr 19, 2024

Conversation

gperdomor
Copy link
Contributor

Description

This PR adds @commitlint/config-nx-scopes package to the container

Motivation and Context

Nx is a very popular tool for monorepos and this change allow the validation of nx scopes using the docker image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Dockerfile.ci Outdated Show resolved Hide resolved
@escapedcat
Copy link
Member

Would you mind rebasing? Then it can be merged

@knocte
Copy link
Contributor

knocte commented Apr 8, 2024

@gperdomor ping?

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@gperdomor
Copy link
Contributor Author

@escapedcat @knocte sorry folks... I didn't see your messages until today... It's rebased now

@escapedcat
Copy link
Member

I assume "container build" will be green once it's merged, right?:
https://github.com/conventional-changelog/commitlint/actions/runs/8738577527/job/24005800445?pr=3913

Wondering if this check needs to run for PRs

@escapedcat escapedcat merged commit aa4df36 into conventional-changelog:master Apr 19, 2024
7 of 8 checks passed
@escapedcat
Copy link
Member

🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants