Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to pure ESM #3850

Merged
merged 22 commits into from
Feb 15, 2024
Merged

feat!: migrate to pure ESM #3850

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9f152a2
feat: migrate to pure ESM
JounQin Jan 12, 2024
4ffd49f
chore: update snapshot
JounQin Jan 15, 2024
24d3570
fix: load `parserPreset` with another `await`
JounQin Jan 15, 2024
b8b8361
test: migrate to vitest
JounQin Jan 27, 2024
4784029
test: remove no replacement `--runInBand` test-ci script
JounQin Jan 29, 2024
e189602
chore: fix code reviews
JounQin Jan 29, 2024
306b0ec
refactor(load): rewrite resolve logic
marcalexiei Jan 31, 2024
70ee03a
fix(config-nx-scopes): fix syntax error
marcalexiei Jan 31, 2024
c01c6f2
feat(resolve-extends): add resolveFrom and loadParserPreset
marcalexiei Jan 31, 2024
ce618e1
feat(load): use resolveFrom and loadParserPreset from resolve-extends
marcalexiei Jan 31, 2024
237b803
test: include only @commitlint/* packages src in coverage
marcalexiei Jan 31, 2024
79e8c8c
test: explicit import vitest utilities
marcalexiei Feb 1, 2024
25a1279
test: remove @jest/globals from dependencies
marcalexiei Feb 1, 2024
e2326a7
fix(resolve-extends): `resolveFrom` output should be platform aware
marcalexiei Feb 1, 2024
429669e
test: restore NO_COLOR to test script
marcalexiei Feb 1, 2024
6aaa6c1
chore: fix linting issues
JounQin Feb 1, 2024
7da4a8c
fix: should use fileURLToPath instead of pathname for Windows compati…
JounQin Feb 3, 2024
c945012
Apply suggestions from code review
JounQin Feb 4, 2024
af4999f
fix: should reuse `cli` instead call `yargs()`
JounQin Feb 4, 2024
0cad810
feat(cli): set terminalWidth as wrap to avoid work break on help
marcalexiei Feb 5, 2024
f214899
Update .eslintrc.cjs
JounQin Feb 5, 2024
85b095b
feat: migrate @commitlint/config-conventional to pure ESM
JounQin Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat: migrate @commitlint/config-conventional to pure ESM
  • Loading branch information
@JounQin
JounQin committed Feb 15, 2024
commit 85b095b21f75f3ef86ffe4c65b0aa0416d858dc3
7 changes: 0 additions & 7 deletions @commitlint/config-conventional/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@
"version": "18.6.2",
"description": "Shareable commitlint config enforcing conventional commits",
"main": "lib/index.js",
"exports": {
".": {
"types": "./lib/index.d.ts",
"import": "./wrapper.mjs",
"require": "./lib/index.js"
}
},
"files": [
"lib/"
],
Expand Down
2 changes: 1 addition & 1 deletion @commitlint/config-conventional/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {pathToFileURL} from 'url';

import lint from '@commitlint/lint';

import {config} from './index.js';
import config from './index.js';

const {rules, parserPreset} = config;

Expand Down
2 changes: 1 addition & 1 deletion @commitlint/config-conventional/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
TargetCaseType,
} from '@commitlint/types';

export = {
export default {
parserPreset: 'conventional-changelog-conventionalcommits',
rules: {
'body-leading-blank': [RuleConfigSeverity.Warning, 'always'] as const,
Expand Down
4 changes: 0 additions & 4 deletions @commitlint/config-conventional/wrapper.mjs
View file
Open in desktop

This file was deleted.