Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Comment #78

Closed
jouderianjr opened this issue Sep 22, 2017 · 8 comments · Fixed by #106
Closed

Ignore Comment #78

jouderianjr opened this issue Sep 22, 2017 · 8 comments · Fixed by #106

Comments

@jouderianjr
Copy link

Hey everyone, I'm using the awesome tool but I have one question.

Using this commit message:

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
# On branch master
# Your branch is up-to-date with 'origin/master'.
#
# Changes to be committed:
#       new file:   text.commit
#
#

I got:

⚠   tense of body must be present-imperative. Verbs in other tenses: starting - present-participle [body-tense]

Is possible ignore commit comments in commitlint?

Thanks in advance!

@marionebl
Copy link
Contributor

marionebl commented Sep 23, 2017

Sure, I will have to check how/if conventional-commits-parser handles comments and decide on what to do with the available parser data. Any chance you can have a look at it yourself?

@jouderianjr
Copy link
Author

Yeah, of course, I will take a look on that :)

@marionebl
Copy link
Contributor

@marionebl
Copy link
Contributor

Opened a PR with conventional-changelog to address this: conventional-changelog/conventional-changelog#231

@morewry
Copy link

morewry commented Oct 13, 2017

I ran into what seems to be the same problem,

⧗   input: chore(*): suggest project setup
⚠   tense of body must be present-imperative. Verbs in other tenses: starting - present-participle,CONTRIBUTING - present-participle [body-tense]
⚠   ...
⚠   found 0 problems, 2 warnings

The commit includes the commented out instructions that all my git commits have always shown, which includes the word "starting." In addition, the commit adds a CONTRIBUTING.md file and it's also picked up.

commit-with-comments

I thought it must be the comment, thanks for having this issue confirm it. Looking forward to the fix!

@jouderianjr
Copy link
Author

Awesome mate! ❤️ Sorry for didn't work on that :( and thanks for the awesome job!

@jouderianjr
Copy link
Author

I'll test it as soon as possible

@marionebl
Copy link
Contributor

conventional-changelog hasn't cut a release since the changes have landed. I might use a published fork in the meantime if this takes longer, stay tuned

marionebl added a commit that referenced this issue Nov 1, 2017
* switch to patched fork of conventional-commits-parser
* add test cases for comments
* fixes #78
marionebl added a commit that referenced this issue Nov 2, 2017
* switch to patched fork of conventional-commits-parser
* add test cases for comments
* fixes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants