Prevent default merge of angular extend

[erikmueller]

I don't know if I'm using the library wrong but it seems it always extends my custom rules with the ones from the angular config: const opts = merge({}, defaults, pick(config, 'extends')); So if I don't want to extend any config but define my own rules, I always end up with angular + my own.

Please enlighten me if I don't see it ;) 💡

[marionebl]

Hey @erikmueller, what does you .conventional-changelog-lintrc look like? Do you use the command line interface or the node api?

[erikmueller]

Hi @marionebl thanks for that quick reply
I placed a .conventional-changelog-lintrc in my root which looks something like this:

{
  "rules": {
    "header-max-length": [2, "always", 80],
    ...

  }
}

So if I do not extend anything but just provide my own rules the defaults.extend gets merged into the resulting config (which is of course not overwritten by my rc because I do not extend)

What I thought when looking at the source: Should't we look if there's a rc provided and if so not merge the default extends? Cause if there's an rc the user will take care of what the rules extend anyway right?

[marionebl]

Thanks for the extended report – your analysis is spot on. I'll have a look into this later today!

[erikmueller]

Thanks a lot. Btw in the meantime I worked around it with simply creating https://github.com/erikmueller/conventional-changelog-lint-config-atom

[marionebl]

Awesome! Mind publishing it to npm? The fix for this is done, testing it now. 🚀

[erikmueller]

When I have time on the weekend I'll definitly do that. Seem to have some problems with type and scope and these awesome :whatever: emoticons. Once I figure that out I'll do a publish ;)

[marionebl]

Relevant changes:

ef9a2b7

Release

v0.3.4