Skip to content

Conversation

jbcaillau
Copy link
Member

@ocots please check unified versions of examples (no more notebooks, single version for basic.jl and goddard) and merge

@github-actions github-actions bot requested a review from ocots April 4, 2023 21:38
@ocots
Copy link
Member

ocots commented Apr 5, 2023

Are you ok if I put the jl files into the doc?

I need a new release of ctdirect then I will do a new release of OC without direct shooting and if you are ok I will put the examples into the doc.

@jbcaillau
Copy link
Member Author

Sure, but then wouldn't it be better to have md files (for Documenter.jl) instead of jl ones? I actually hesitated but wanted to put forward the possibility to run the code directly. And this kind of jl file that includes markdown docstrings is well rendered on, e.g., Pluto 1 (or using some vscode extensions...)

Are you ok if I put the jl files into the doc?

I need a new release of ctdirect then I will do a new release of OC without direct shooting and if you are ok I will put the examples into the doc.

Footnotes

  1. https://juliahub.com/ui/Notebooks/cadojo/Astrodynamics?type=packages

@ocots
Copy link
Member

ocots commented Apr 5, 2023

To put them on the doc, I will have to change them to md files. This seems the most usual to do for the moment. The jl files are for concrete applications. Not doc.

@jbcaillau
Copy link
Member Author

Right now I need to have them running (Documenter.jl will also run them but well...) So please keep them as jl files and merge. See also this post

@jbcaillau jbcaillau merged commit a5c55c1 into main Apr 6, 2023
@jbcaillau jbcaillau deleted the examples branch April 6, 2023 16:18
@ocots
Copy link
Member

ocots commented Apr 6, 2023

I do it by the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants