Skip to content

82 doc add new instances benchmark #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

82 doc add new instances benchmark #83

wants to merge 30 commits into from

Conversation

@AmielMetier
Copy link
Collaborator

@AmielMetier AmielMetier commented Nov 5, 2025

No description provided.

@AmielMetier AmielMetier linked an issue Nov 5, 2025 that may be closed by this pull request
[Doc] Add new instances benchmark #82
Open
@github-actions github-actions bot requested a review from ocots November 5, 2025 21:09
@AmielMetier AmielMetier added run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. documentation Improvements or additions to documentation labels Nov 5, 2025
@control-toolbox control-toolbox deleted a comment from github-actions bot Nov 6, 2025
@control-toolbox control-toolbox deleted a comment from github-actions bot Nov 7, 2025
@ocots ocots removed the documentation Improvements or additions to documentation label Nov 7, 2025
@ocots ocots added run bench core-moonshot Trigger the workflow to make the core benchmark on moonshot and the documentation. and removed run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. run bench core-moonshot Trigger the workflow to make the core benchmark on moonshot and the documentation. labels Nov 7, 2025
@ocots
Copy link
Member

ocots commented Nov 7, 2025

New benchmarks being computed here: https://github.com/control-toolbox/CTBenchmarks.jl/actions/runs/19170942588.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

✅ Benchmark and Documentation Complete

The automated workflow has completed successfully! 🎉

✅ Completed Tasks

  • 📊 Benchmarks: core-ubuntu-latest executed and results saved to your branch
  • 📚 Documentation: Documentation updated successfully
  • 🔄 Integration: All changes integrated properly

📖 Documentation Preview

📋 Results

  • 🎯 Benchmark results have been committed to your feature branch
  • 📚 Documentation has been regenerated with the latest benchmark data

🔗 Links

🤖 This notification was automatically generated 2025-11-08 22:30:14 (UTC-2)

@github-actions
📊 Add benchmark results
31b488b 
Generated by reusable benchmark workflow

Results saved to /scratch/github-actions/actions_runner_control_toolbox/_work/CTBenchmarks.jl/CTBenchmarks.jl/docs/src/assets/benchmarks/core-moonshot/data.json

Includes environment TOMLs and benchmark script
@github-actions github-actions bot force-pushed the 82-doc-add-new-instances-benchmark branch from e2a99d1 to 31b488b Compare November 7, 2025 16:28
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025 •
edited
Loading

❌ Workflow Failed

The benchmark and documentation workflow encountered failures:

Failed Jobs

  • ❌ Benchmarks

🔍 Troubleshooting

  • Check the workflow run for detailed logs
  • Verify that all required dependencies are available
  • Ensure the benchmark code is functioning correctly

🔄 Next Steps

  • Fix any issues identified in the logs
  • Push new commits to retry, or
  • Remove and re-add the benchmark label to restart

🤖 This notification was automatically generated 2025-11-08 17:12:37 (UTC-2)

@ocots
Copy link
Member

ocots commented Nov 7, 2025 •
edited
Loading

@AmielMetier @HediChennoufi Don't forget to update the documentation:

CTBenchmarks.jl/docs/src/benchmark-core.md.template

Line 19 in 31b488b

- **Grid sizes:** 200, 500, 1000 discretisation points

CTBenchmarks.jl/docs/src/benchmark-core.md.template

Line 56 in 31b488b

- **Grid sizes:** 1000, 5000, 10000 discretisation points

to be consistent with:

CTBenchmarks.jl/benchmarks/core-ubuntu-latest.jl

Line 28 in 31b488b

grid_sizes=[200, 500, 1000, 2000, 5000],

CTBenchmarks.jl/benchmarks/core-moonshot.jl

Line 26 in 31b488b

grid_sizes=[1000, 5000, 10000, 20000],

when the JSON will be updated and the documentation up to date.

Note

I have removed ducted_fan from the benchmark on ubuntu-latest since it seems to block the process: https://github.com/control-toolbox/CTBenchmarks.jl/actions/runs/19170942588/job/54835639441.

@ocots ocots added run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. and removed run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. labels Nov 7, 2025
@ocots ocots added the run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. label Nov 8, 2025
@ocots ocots removed the run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. label Nov 8, 2025
@ocots
Copy link
Member

ocots commented Nov 8, 2025

@AmielMetier @HediChennoufi Don't forget to update the documentation:

CTBenchmarks.jl/docs/src/benchmark-core.md.template

Line 19 in 31b488b

- **Grid sizes:** 200, 500, 1000 discretisation points

CTBenchmarks.jl/docs/src/benchmark-core.md.template

Line 56 in 31b488b

- **Grid sizes:** 1000, 5000, 10000 discretisation points

to be consistent with:

CTBenchmarks.jl/benchmarks/core-ubuntu-latest.jl

Line 28 in 31b488b

grid_sizes=[200, 500, 1000, 2000, 5000],

CTBenchmarks.jl/benchmarks/core-moonshot.jl

Line 26 in 31b488b

grid_sizes=[1000, 5000, 10000, 20000],

when the JSON will be updated and the documentation up to date.

Note

I have removed ducted_fan from the benchmark on ubuntu-latest since it seems to block the process: https://github.com/control-toolbox/CTBenchmarks.jl/actions/runs/19170942588/job/54835639441.

I have remove N=5000 since it takes too much time. On GitHub hosted runners, the maximum limit is 360 minutes.

@ocots ocots added the run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation. label Nov 8, 2025
@github-actions
📊 Add benchmark results (core-ubuntu-latest)
67b47ad 
Results saved to /home/runner/work/CTBenchmarks.jl/CTBenchmarks.jl/docs/src/assets/benchmarks/core-ubuntu-latest/data.json

Includes environment TOMLs and benchmark script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocots ocots Awaiting requested review from ocots

@HediChennoufi HediChennoufi Awaiting requested review from HediChennoufi

@jbcaillau jbcaillau Awaiting requested review from jbcaillau

At least 1 approving review is required to merge this pull request.

Assignees

@ocots ocots

Labels

run bench core-ubuntu-latest Trigger the workflow to make the core benchmark on ubuntu latest and the documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Doc] Add new instances benchmark

4 participants

@AmielMetier @ocots @HediChennoufi