Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Nette 2.4 #34

Merged
merged 7 commits into from
May 12, 2021
Merged

Support for Nette 2.4 #34

merged 7 commits into from
May 12, 2021

Conversation

f3l1x
Copy link
Member

@f3l1x f3l1x commented Feb 5, 2021 •
edited
Loading

  • Composer scripts -> Makefile
  • Travis -> Github Actions
  • Added extension for Nette 2.4
  • Run codecoverage via coveralls
  • ✅ PHP 8 is failing because latest version of bunny/bunny does not support PHP 8 (Support PHP 8 jakubkulhan/bunny#102 (comment))
  • ✅ At this moment, there is no significant difference between RabbitMQExtension24 and RabbitMQExtension, but there will be, so it's better to rely on this class since now.
$ composer require contributte/rabbitmq:dev-feature/nette-2.4

extensions:
  # Nette 3.0+
  rabbitmq: Contributte\RabbitMQ\DI\RabbitMQExtension

  # Nette 2.4
  rabbitmq: Contributte\RabbitMQ\DI\RabbitMQExtension24

@f3l1x f3l1x force-pushed the feature/nette-2.4 branch from 9e6958b to 5fe2ec3 Compare February 5, 2021 07:33
paveljanda
paveljanda reviewed May 12, 2021
View reviewed changes
.editorconfig Outdated
indent_size = tab
tab_width = 4

[{*.json,*.yml,*.md}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f3l1x Could you, please, remove json from this list? Thanks a lot!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@f3l1x f3l1x force-pushed the feature/nette-2.4 branch from 5fe2ec3 to ee3e1de Compare May 12, 2021 08:45
@f3l1x f3l1x force-pushed the feature/nette-2.4 branch from ee3e1de to 47878cd Compare May 12, 2021 08:49
@f3l1x f3l1x changed the title WIP: Support for Nette 2.4 Support for Nette 2.4 May 12, 2021
@paveljanda
Copy link
Member

Awesome, man, thanks!

@paveljanda paveljanda merged commit 95c61b6 into master May 12, 2021
@f3l1x f3l1x deleted the feature/nette-2.4 branch May 12, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveljanda paveljanda paveljanda left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@f3l1x @paveljanda