test(solidity): unit test tmlanguage syntax #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambacha
commented
Feb 25, 2025
There was a problem hiding this comment.
Contract declarations with inheritance - the is keyword and contract names aren't being properly scoped
Function declarations - parameters, modifiers, and return types aren't being properly scoped
Punctuation - commas, parentheses, etc. aren't being properly scoped
Various other token scoping issues
sambacha
added a commit
that referenced
this pull request
Feb 25, 2025
* feat(vscode): prepare v2 release * fix(vscode): activate on load Certain extensions require this setting to work correctly, for example <https://github.com/runtimeverification/ercx-vscode/blob/master/README.md#:~:text=You%20need%20to%20install%20an%20extension%20for%20Solidity%20syntax%20highlighting%20for%20this%20extension%20to%20work%20as%20it%20activates%20onLanguage%3Asolidity> * feat: add gaes.tmLanguage.jsonc (#21) see <https://github.com/fjl/geas> * feat(solidity): add support for custom types (#19) * test(solidity): unit test tmlanguage syntax (#26) * ci(nodejs-ci): upgrade * fix(ci): on pull request * fix(vsce): use @vscode/vsce * fix(solidity): stand back i know regex * feat(vsce): v2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the contract inheritance pattern to properly handle commas between parent contracts
Added a specific pattern for function parameters to correctly scope them
Fixed the event declarations to properly scope the event name, parameters, and indexed modifier
Fixed the enum declarations to properly scope the enum name, members, and commas
Fixed the mapping declarations to properly scope the mapping keyword, parameters, and => operator
Fixed the struct declarations to properly scope the struct name, fields, and semicolons
-Fixed the user-defined type declarations to properly scope the type keyword, name, is keyword, and base type