Skip to content

Fixes crash on full screen scrolling #1789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

Fixes crash on full screen scrolling #1789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@
<li>Adds ability to name tabs (#1690)</li>
<li>Adds dynamic loading of conpty.dll to allow mouse mode on Windows 10</li>
<li>Fix empty history jump (#1781)</li>
<li>Fixes crash on full screen scrolling</li>
</ul>
</description>
</release>
Expand Down
4 changes: 2 additions & 2 deletions src/vtbackend/Grid.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,8 @@ void Grid<Cell>::scrollDown(LineCount vN, GraphicsAttributes const& defaultAttri

rotateBuffersRight(n);

for (Line<Cell>& line: mainPage().subspan(0, unbox<size_t>(n)))
line.reset(defaultLineFlags(), defaultAttributes);
for (auto const i: ranges::views::iota(0, *n))
_lines[i].reset(defaultLineFlags(), defaultAttributes);
return;
}

Expand Down
Loading