Skip to content

Do not compile with c++17 in actions since we compile with c++20 anyway #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

Do not compile with c++17 in actions since we compile with c++20 anyway #7

merged 1 commit into from
Oct 9, 2023

Conversation

Yaraslaut
Copy link
Member

in CMakeLists.txt we require C++20

boxed-cpp/CMakeLists.txt

Line 16 in f15e640

target_compile_features(boxed-cpp INTERFACE cxx_std_20)

christianparpart
christianparpart approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true

@christianparpart christianparpart merged commit b7885c7 into master Oct 9, 2023
@christianparpart christianparpart deleted the fix/std_version_in_actions branch October 9, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaraslaut @christianparpart