Conversation
Contributor
|
LGTM |
unclejack
reviewed
Mar 2, 2017
| DEFAULT_DOCKER_VERSION := 1.12.6 | ||
| SHELL := /bin/bash | ||
| EXCLUDE_DIRS := bin docs Godeps scripts test vagrant vendor install | ||
| EXCLUDE_DIRS := bin docs Godeps scripts test vagrant vendor install |
Contributor
There was a problem hiding this comment.
There's some trailing whitespace at the end of this line.
unclejack
reviewed
Mar 2, 2017
| CONTIV_K8=1 cd vagrant/k8s/ && ./start_sanity_service.sh | ||
| cd $(GOPATH)/src/github.com/contiv/netplugin/scripts/python && PYTHONIOENCODING=utf-8 ./createcfg.py -scheduler 'k8' | ||
| CONTIV_K8=1 CONTIV_NODES=3 go test -v -timeout 540m ./test/systemtests -check.v -check.f "00SSH|Basic|Network|Policy|TestTrigger|ACIM|HostBridge|Netprofile" | ||
| CONTIV_K8=1 CONTIV_NODES=3 go test -v -timeout 540m ./test/systemtests -check.v -check.f "00SSH|TestBasic|TestNetwork|TestPolicy|TestTrigger" |
Contributor
There was a problem hiding this comment.
There's some trailing whitespace at the end of this line.
Contributor
|
@abhinandanpb Pls rebase. |
Contributor
|
@jojimt: This still needs some more changes to be made and some other changes to be reverted. Some tests were failing the last time I've tried to run the tests. @abhinandanpb is already aware of those issues and he's working on those changes. |
adding multiple uplinks
Member
Author
|
@jojimt done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is follow up to #739
These are the only 2 minor fixes needed to run k8s sanity
New test case: