Cleanup Readme #137
Merged
Cleanup Readme #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jainvipin can you review this change? |
erikh
force-pushed
the
fix-readme
branch
5 times, most recently
from
70ce5d4 to
7f58732
Compare
…ation instructions Signed-off-by: Erik Hollensbe <erik+github@hollensbe.org>
Contributor
Author
|
@jainvipin I have made the edits, PTAL. |
There was a problem hiding this comment.
sorry I should have noticed this earlier. Do we need to bring them up explicitly? I thought you were going to incorporate this as part of make-demo. Or is that a separate PR? Even if it is, the doc could be updated now.
Contributor
Author
There was a problem hiding this comment.
That's a separate bit of code I have yet to implement. For now, they need to start it themselves.
Contributor
Author
|
Going to merge this, I think it's satisfactory for now. Sorry if I jumped the gun. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates #133, so please merge that first.
This adds simplified instructions based on the build system in #133 and additional cleanups such as word wrap and some whitespace changes.