-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat: make commit signature configurable #8149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make commit signature configurable #8149
Conversation
Add disableCommitSignature config option to allow users to disable the automatic inclusion of Continue attribution in commit messages. - Add disableCommitSignature to config interfaces - Update system message to conditionally include signature - Add comprehensive tests for the new behavior - Update documentation in config.yaml reference Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 5 files
Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
The disableCommitSignature property was added to the AssistantUnrolled schema but the package build was failing due to missing @continuedev/config-types dependency. Installed the dependency and rebuilt the package to update TypeScript types. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev>
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting changes to delay merging as we don't currently top level settings like this to config yaml
|
@rossigee currently settings like this live in |
* Add notion cookbook * Add notion draft * Add draft notion cookbook * Update docs/guides/notion-continue-cookbook.mdx Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * Change cookbook to guide using API since MCP doesn't work * Move out of MCP cookbooks in overview * Apply suggestion from @cubic-dev-ai[bot] Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> --------- Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Co-authored-by: Brian Douglas <bdougie@users.noreply.github.com>
- Added dismissable banner to docs.json - Banner promotes CLI v1.4.49 release and links to MCP Cookbooks - Banner is dismissable for better UX Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <noreply@continue.dev> Co-authored-by: Username <bekah@continue.dev>
This reverts commit a6daeb8.
- Move disableCommitSignature from config.yaml to GlobalContext for user preferences - Add /set slash command for configuring CLI preferences - Update documentation to reflect new user-configurable setting - Add comprehensive tests for the new functionality - Maintain backward compatibility with default attribution enabled The setting is now stored in GlobalContext and can be configured using: - /set disableCommitSignature true (disable attribution) - /set disableCommitSignature false (enable attribution, default)
…ossigee/feature/disable-commit-signature-config
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossigee went over this with @TyDunn again today, sorry for the back and forth but we're thinking the slash command doesn't quite feel right. We could build a TUI menu where users could easily toggle but it doesn't solve CICD scenarios and the global context is a bit saturated (I know I requested putting it there).
We're thinking let's rip out the persisted setting altogether and just use an environment variable like CONTINUE_CLI_DISABLE_COMMIT_SIGNATURE. Thoughts on this?
|
That's a much better, simpler approach. |
Description
Added a new configuration option
disableCommitSignatureto allow users to disable the automatic inclusion of Continue attribution in commit messages generated by the CLI. This makes the signature configurable for users who prefer not to include it.Key changes:
disableCommitSignatureboolean optionAI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[Not applicable for this configuration change.]
Tests
Added tests in
extensions/cli/src/systemMessage.test.tsto verify the signature is included or excluded based on thedisableCommitSignatureconfig option.Summary by cubic
Made the Continue commit attribution optional for CLI-generated commits via a new disableCommitSignature config. By default the signature is included; set disableCommitSignature: true to remove it.
New Features
Migration