Skip to content

Revert "Fix image drop from main editor" #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

Revert "Fix image drop from main editor" #7908

merged 1 commit into from
Sep 22, 2025

Conversation

@RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 22, 2025 •
edited by cubic-dev-ai bot
Loading

Reverts #7205

Summary by cubic

Reverts the prior image-drop fix and simplifies handling to file-only drops in the main editor. Removes VS Code resource URL support and the related IDE protocol.

  • Refactors
    • Removed readFileAsDataUrl from the core protocol and VS Code extension.
    • Deleted VS Code resource URL parsing/HTML handlers; drops from VS Code resource URLs are no longer supported.
    • Dropped ProseMirror-based drop handling; image insertion now handled in TipTapEditor onDrop.
    • Drag overlay now listens to global drag events and auto-hides; pointer-events enabled.
    • VS Code config: preLaunchTask switched to build-with-packages; removed gui:build task.

@RomneyDa RomneyDa requested a review from a team as a code owner September 22, 2025 23:29
@RomneyDa RomneyDa requested review from Patrick-Erichsen and removed request for a team September 22, 2025 23:29
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 22, 2025
@github-actions
Copy link

github-actions bot commented Sep 22, 2025

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.

💡 To request a new detailed review, comment @continue-detailed-review

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Sep 22, 2025
View reviewed changes
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 22, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 22, 2025
@RomneyDa RomneyDa merged commit 5262cf2 into main Sep 22, 2025
57 of 60 checks passed
@RomneyDa RomneyDa deleted the revert-7205-fix-image-drop-from-main-editor branch September 22, 2025 23:43
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 22, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2025
@RomneyDa
Copy link
Collaborator Author

RomneyDa commented Sep 22, 2025

reopened here
#7910

@sestinj
Copy link
Contributor

sestinj commented Sep 24, 2025

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

@Patrick-Erichsen Patrick-Erichsen Patrick-Erichsen approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Issues and PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RomneyDa @sestinj @Patrick-Erichsen