Mcp streamable http #5829
Merged
Mcp streamable http #5829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des StreamableHTTP transport as of 1.10.0.
…sport case statement
|
Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic. |
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:M
|
@maxxrdrgz looks like you might have one test failing. Thanks for getting this PR together. |
|
@chezsmithy yep. I took a quick look at it this morning and find it a bit confusing. I plan on having another look at it later today. Thanks! |
- stdio needs about ~30ms to fully connect now. not 1ms.
RomneyDa
previously approved these changes
May 26, 2025
There was a problem hiding this comment.
@maxxrdrgz this looks great! Could you pull main and resolve merge conflicts? Would love to get this merged
|
@RomneyDa done :-) |
3 tasks
RomneyDa
approved these changes
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added initial implementation for supporting the StreamableHTTP transport from the MCP sdk. It's a pretty simple implementation. I tested this on an Arm Mac. Addresses #5738 and #5790 .
From what I've seen so far, StreamableHTTP looks to be a drop in replacement for SSE and that's more or less what we see here with my PR.
More options may be needed in the MCPConnection.ts. But this is a good starting point that allows for http headers.
Checklist