Skip to content

feat: add stream in defaultCompletionOptions yaml #5818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

uinstinct
Copy link
Contributor

Description

The stream option was missing in config.yaml
Some users using a proxy server may not be streaming the response. Hence we might need this option to be available.

Reference discussion: https://discord.com/channels/1108621136150929458/1375084108677517362/1375447221578895450

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

  1. Run this simple express ollama proxy server
  2. Create a model with provider: ollama and apiBase: http://localhost:4000/ollama/ and model: qwen2.5-coder:1.5b
  3. add stream: false in the above model's defaultCompletionOptions
  4. chat with the model and see that responses work
  5. if stream: true, the model will not able to chat

@uinstinct uinstinct requested a review from a team as a code owner May 23, 2025 14:01
@uinstinct uinstinct requested review from sestinj and removed request for a team May 23, 2025 14:01
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 23, 2025
Copy link

netlify bot commented May 23, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit 09c403f
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/68307fcf4f466800085496ce

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the test!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 26, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 26, 2025
@sestinj sestinj merged commit 74eb24a into continuedev:main May 26, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
@uinstinct uinstinct deleted the yaml-stream branch May 26, 2025 04:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants