Skip to content

fix: add Delphi/Pascal syntax highlighting support #5732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented May 19, 2025

Description

#4771 was supposed to fix Pascal highlighting support but it actually removed Delphi support in the process. I'm just trying it again as I'm puzzled by the reason (delphi didn't exist according to tests).

Fixes #3586

Checklist

  • I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

Screenshot 2025-05-19 at 09 53 15

Tests

  • ask a chat model to write a "hello world" program in Pascal.
  • pascal snippet should be highlighted.

Summary by cubic

Restored Delphi/Pascal syntax highlighting support in the markdown preview so Pascal code snippets are highlighted correctly.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon requested a review from a team as a code owner May 19, 2025 08:10
@fbricon fbricon requested review from RomneyDa and removed request for a team May 19, 2025 08:10
Copy link

netlify bot commented May 19, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit cfcb06b
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/682ae772ca03c40008833315

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 19, 2025
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@fbricon
Copy link
Contributor Author

fbricon commented May 19, 2025

I suspect the "delphi didn't exist according to tests" statement might have been caused by referencing Delphi.js instead of delphi.js in the original commit, which would obviously fail when running on a case-sensitive OS (hello Linux)

@RomneyDa RomneyDa closed this May 19, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs May 19, 2025
@RomneyDa RomneyDa reopened this May 19, 2025
@github-project-automation github-project-automation bot moved this from Done to In Progress in Issues and PRs May 19, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 19, 2025
@RomneyDa RomneyDa merged commit 52d2451 into continuedev:main May 20, 2025
89 of 92 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Pascal language problem
2 participants