chore(JB): cleanup applyToFile logic
#5680
Merged
+839
−436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrick-Erichsen
requested review from
tomasz-stefaniak
and removed request for
a team
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:XXL
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
|
I have read the CLA Document and I hereby sign the CLA |
...ellij/src/test/kotlin/com/github/continuedev/continueintellijextension/utils/BrowserUtils.kt
Show resolved
Hide resolved
Patrick-Erichsen
requested review from
RomneyDa
and removed request for
tomasz-stefaniak
RomneyDa
reviewed
May 16, 2025
gui/src/redux/slices/sessionSlice.ts
Outdated
| @@ -47,7 +47,7 @@ type SessionState = { | |||
| symbols: FileSymbolMap; | |||
| mode: MessageModes; | |||
| codeBlockApplyStates: { | |||
| states: ApplyState[]; | |||
| states: UpdateApplyStatePayload[]; | |||
There was a problem hiding this comment.
Since CodeToEdit and ApplyState are stored statefully and passed around in other places, I think the original naming makes more sense than adding payload, and is more concise
RomneyDa
approved these changes
May 16, 2025
There was a problem hiding this comment.
@Patrick-Erichsen does this include that last bug we found with partial rejection/acceptance messing up the file or should we open new ticket for that?
|
@RomneyDa that is fixed in a subsequent PR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by mrge
Refactored the IntelliJ apply-to-file logic into a new ApplyToFileHandler class for better structure and testability, and updated related types and usages across the codebase.
EditorUtilswith additional editor related functionality