Skip to content

Feat: support maxStopWords model config option in yaml #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025

Conversation

t-kulmburg
Copy link

@t-kulmburg t-kulmburg commented May 14, 2025

Description

I described the problem in this issue: #5663

Whats changed is that the maxStopWords config option that was present in the deprecated JSON but not in the YAML configuration is added to the YAML schema.

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

Tests

I tested it using the vscode debug feature, with the config shown in the issue that initially led to the described error. After the changes, the maxStopWords config option is correctly working when using YAML config, leading to the same result as if the JSON version of the same config would be used.


Summary by mrge

Added support for the maxStopWords model config option in YAML, matching the previous JSON config behavior.

  • New Features
    • You can now set maxStopWords in YAML model configs to control the maximum number of stop words.

@t-kulmburg t-kulmburg requested a review from a team as a code owner May 14, 2025 20:22
@t-kulmburg t-kulmburg requested review from sestinj and removed request for a team May 14, 2025 20:22
Copy link

netlify bot commented May 14, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 5f132ee
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6824fba00657d10008adc35a
😎 Deploy Preview https://deploy-preview-5675--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 14, 2025
Copy link

github-actions bot commented May 14, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@t-kulmburg t-kulmburg changed the title Feat: Support maxStopWords model config option in yaml Feat: support maxStopWords model config option in yaml May 14, 2025
@t-kulmburg
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@tkulmburg-nc
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@t-kulmburg
Copy link
Author

sorry i mixed up my users when committing

Copy link
Contributor

@sestinj sestinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 25, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 25, 2025
@sestinj sestinj merged commit 0ca3004 into continuedev:main May 25, 2025
35 of 36 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs May 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants