-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Feat: support maxStopWords model config option in yaml #5675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for continuedev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
I have read the CLA Document and I hereby sign the CLA |
sorry i mixed up my users when committing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Description
I described the problem in this issue: #5663
Whats changed is that the
maxStopWords
config option that was present in the deprecated JSON but not in the YAML configuration is added to the YAML schema.Checklist
Screenshots
Tests
I tested it using the vscode debug feature, with the config shown in the issue that initially led to the described error. After the changes, the
maxStopWords
config option is correctly working when using YAML config, leading to the same result as if the JSON version of the same config would be used.Summary by mrge
Added support for the maxStopWords model config option in YAML, matching the previous JSON config behavior.