fix: use cmd for windows MCP connections
#5631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:M
|
Could add docker one not sure if needed might be worth an extra peek. Half of our featured MCP servers are docker command |
3 tasks
RomneyDa
approved these changes
May 12, 2025
| @@ -232,14 +280,14 @@ class MCPConnection { | |||
| ]); | |||
| } catch (error) { | |||
| // Otherwise it's a connection error | |||
| let errorMessage = `Failed to connect to MCP server ${this.options.name}`; | |||
| let errorMessage = `Failed to connect to "${this.options.name}"\n`; | |||
There was a problem hiding this comment.
nitpick - new line should be at beginning of additions, not here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #4913 #4874 #4791
When connecting to an MCP server via
StdioClientTransporton Windows, we need to execute commands such asnpxanduvxthrough thecmd.exeinterpreter.Testing instructions
Summary by mrge
Fixed MCP server connections on Windows by running batch commands like
npxanduvxthroughcmd.exeto ensure proper execution.