feat: manual ripgrep downloads for JB #5582
Merged
+443
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:L
dosubot
bot
added
size:XL
|
@uinstinct @fbricon - mind taking a look at this since you both have some context from the recent ripgrep PR. |
uinstinct
reviewed
May 9, 2025
tomasz-stefaniak
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #5542
This PR introduces a manual step in the build process for JetBrains to install
ripgrepfor the respective OS/arch.In our VS Code build process, we don't need to do this because we run builds in CI on the appropriate runners for each OS/arch. But for JB, we need to upload a single zip that contains all the required deps for each OS/arch, so we only run on a single runner (
macOS-latest), which then causes us to only install the ripgrep binary for that platform.