-
Notifications
You must be signed in to change notification settings - Fork 2.9k
do not allow to toggle config page from command palette #5224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for continuedev canceled.
|
Hey @uinstinct , I've watched the video a few times but I'm still a bit confused. Why do we need both of the comamnds? |
Sure, I will try to explain. Toggling using command palette with |
@uinstinct nice find, I'd consider just removing the toggle functionality from the original command. @Patrick-Erichsen thoughts? |
Yeah +1 to Dallin, we have a back button on the settings page so I don't think the settings icon needs to be overly clever and have toggle functionality. |
We could also remove other commands present both with an icon and in the command palette (those including settings, view history, new session, open in new window). |
I think some users find value in being able to quickly use the command palette to navigate instead of clicking around the GUI. I think Dallin's point (that I agree with) is just to keep the logic simple and not have it toggle. |
Here is the updated working: updated.mp4 |
Description
One can toggle the config page from the command palette using the
continue: open settings
command. This creates some confusion when the config page is already open.This PR fixes this by separating
continue.openConfigPage
with a newcontinue.openConfigPageFromPalette
command.Checklist
Screenshots
before.mp4
after.mp4
Testing instructions
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]