Skip to content

do not allow to toggle config page from command palette #5224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025

Conversation

uinstinct
Copy link
Contributor

Description

One can toggle the config page from the command palette using the continue: open settings command. This creates some confusion when the config page is already open.

This PR fixes this by separating continue.openConfigPage with a new continue.openConfigPageFromPalette command.

Checklist

  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

before.mp4
after.mp4

Testing instructions

[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]

@uinstinct uinstinct requested a review from a team as a code owner April 18, 2025 10:38
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team April 18, 2025 10:38
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit aaf4a2b
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/68106bd8bbc48d0008749512

@Patrick-Erichsen
Copy link
Collaborator

Hey @uinstinct , I've watched the video a few times but I'm still a bit confused. Why do we need both of the comamnds?

@uinstinct
Copy link
Contributor Author

uinstinct commented Apr 18, 2025

Hey @uinstinct , I've watched the video a few times but I'm still a bit confused. Why do we need both of the comamnds?

Sure, I will try to explain. Toggling using command palette with continue: open settings is somewhat unintuitive. It opens the chat area when the settings ui is open (despite the given command).
Toggling with the settings button on the gui is intuitive because there is instant feedback between the chat and config page views. User understands we are switching between those 2 views.

@RomneyDa
Copy link
Collaborator

RomneyDa commented Apr 23, 2025

@uinstinct nice find, I'd consider just removing the toggle functionality from the original command. @Patrick-Erichsen thoughts?

@Patrick-Erichsen
Copy link
Collaborator

Yeah +1 to Dallin, we have a back button on the settings page so I don't think the settings icon needs to be overly clever and have toggle functionality.

@uinstinct
Copy link
Contributor Author

We could also remove other commands present both with an icon and in the command palette (those including settings, view history, new session, open in new window).
Or should we just remove the settings?

@Patrick-Erichsen
Copy link
Collaborator

I think some users find value in being able to quickly use the command palette to navigate instead of clicking around the GUI. I think Dallin's point (that I agree with) is just to keep the logic simple and not have it toggle.

@uinstinct
Copy link
Contributor Author

Here is the updated working:

updated.mp4

@sestinj sestinj merged commit 86db4c3 into continuedev:main Apr 29, 2025
32 checks passed
@uinstinct uinstinct deleted the config-page-palette branch April 30, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants