Profiles#14

Merged

gabe-l-hart merged 31 commits intomainfrom

Dec 19, 2025

Collaborator

gabe-l-hart commented Dec 19, 2025 •

edited

Loading

~~## DRAFT STATUS~~

~~There are issues in the core package that make it difficult to add additional profiles due to the password change requirement. Until a workaround is solved, this will stay in draft.~~

We've solved this issue by adding the ability to create profiles via the CLI and managing a virtual default profile corresponding to the old default behavior.

Description

This PR introduces the ability to manage separate profiles, matching the corresponding functionality in the Desktop App. It relies on the functionality in contextforge-org/contextforge-desktop#4 which places the profile data into the CONTESTFORGE_HOME directory. This allows the CLI and the Desktop App to interoperate on profile settings without tightly coupling the two (the CLI will still work seamlessly without configured profiles).

Changes

Add a collection of tools for working with profiles in cforge/profile_utils.py
Add a collection of tools for working with encrypted saved credentials in cforge/credential_store.py
Add a new set of commands in cforge/commands/settings/profiles.py
Update all existing commands to use a common utility for fetching the server URL that is profile-aware
Add profile information to cforge whoami
Perform auto-login when possible with saved credentials

Testing

Full unit test coverage with minimal mocking

Definition Of Done

This PR contains documentation
- Yes
- NO (explain): The only docs we really have right now are in --help and this is covered there. More thorough docs to come!
- N/A
This PR contains unit tests
- Yes
- NO (explain)
- N/A
This PR has been tested for backwards compatibility
- Yes
- NO (explain)
- N/A

gabe-l-hart added 25 commits

December 17, 2025 12:54


          feat: Initial implementation of profiles with Bob

123ad46

This is the unedited Bob output that will be cleaned up in later commits

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Refactor Bob's version for cleaner centralization of base URL

b8044eb

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: Put whole id in profile table

44b188b

This is needed so you can actually use the `get` by ID

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: (unrelated) fix isActive -> enabled that got missed in prompts

ea282c5

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: Only open the store file for reading if it exists

759ad9a

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Update tests to mock get_base_url correctly

a915956

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: Refactor the structure of the profiles command to match the others

1c63595

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Add tests for profile utils and new common helper

3cff323

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Add tests for profiles commands

0cb9ca8

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Add validation logic to profile structures

912c17e

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Full test coverage for profiles commands

7f256ed

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: Remove unreachable validation condition

cb46a68

Since we validate only a single active profile earlier and we short-circuit
for no active profile, we can't possibly have other active profiles that
aren't the active profile.

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Unit tests for validation errors

8fc4e94

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Use a suffix for per-profile tokens

96a41cc

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Report active profile in whoami

938466a

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Implement auto-login matching Desktop app stored credentials

3b55c3a

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          chore: Explicitly add cryptography dep

a6a9920

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Add unit tests for credential_store.py

e1cc95e

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Add tests to cover auto-login in common

5515d53

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Add cforge profiles create

3347a06

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Add logic to manage a virtual default profile

00cf980

This profile will not be saved in the profiles file but will show up when
profiles are listed and will allow users to switch to the default profile.

We still need to figure out how to disable this if there is a local profile
from the desktop app.

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test(fix): Fix the mock_everywhere test util to also mock in conftest

7749adb

There are several methods in conftest that invoke get_settings and we need
them to hit the mocked settings if used.

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: Remove unreachable code paths that handled no active profile

027e286

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>

0062ba7

#13
Branch: Profiles-13


          feat: Don't show virtual default if desktop default is present

f7eaca3

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>

gabe-l-hart force-pushed the Profiles-13 branch from d0cf30b to f7eaca3 Compare

December 19, 2025 21:25

gabe-l-hart marked this pull request as ready for review

December 19, 2025 21:26

gabe-l-hart commented

View reviewed changes

cforge/commands/settings/profiles.py Outdated Show resolved Hide resolved

gabe-l-hart added 2 commits

December 19, 2025 14:33


          fix: Remove profiles_current

8bf63e0

This is redundant with cforge whoami

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: Remove unnecessary if guard for active profile in whoami

7a688e5

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>

gabe-l-hart commented

View reviewed changes

cforge/commands/settings/profiles.py Outdated Show resolved Hide resolved

cforge/commands/settings/whoami.py Outdated Show resolved Hide resolved

gabe-l-hart added 4 commits

December 19, 2025 15:37


          fix: Fix get_active_profile to always return a profile

10cbf7f

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          feat: Add the ability to create a profile from a data file

08b55d9

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          fix: No need to handle bad state profile store

9d8ead4

This is handled during schema validation on load

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>


          test: Cover the case of a bad data file for profiles_create

51fc54d

#13
Branch: Profiles-13

Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>

gabe-l-hart merged commit c309171 into main

4 checks passed

gabe-l-hart deleted the Profiles-13 branch

December 19, 2025 23:00

gabe-l-hart mentioned this pull request

[Feature Request] Support for multiple profiles #13

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet