-
Notifications
You must be signed in to change notification settings - Fork 0
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values, update form-data version and handling empty server command inputs. #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CL-2062 | +Harshi | Fix skip environment variables option with --vari…
fix: suppress error message in non-development environments
Add AGENTS.md file
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to support multiple selections
fix: handle empty server command input properly
Fix issue regarding skipping env variables, suppressing non-dev error messages, parsing URL-formatted env values and handling empty server command inputs.
Update form-data to 4.0.4 and add dependency overrides
fix: Update form-data to 4.0.4 and add dependency overrides
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements multiple fixes related to environment variable handling, Apollo client message suppression, and server command input validation. It updates dependencies and adds comprehensive test coverage for the new functionality.
Key Changes:
- Adds global console patching to suppress Apollo client deprecation warnings in non-development environments
- Implements proper environment variable parsing for URL-formatted values (values containing colons)
- Enables the
--variable-typeflag to accept multiple values for flexible environment variable configuration - Improves server command handling to properly skip empty or whitespace-only inputs
- Updates form-data to exact version 4.0.4 and @apollo/client to ^3.14.0 with package overrides for transitive dependencies
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/apollo-client.ts | Adds global console patching to filter Apollo-specific error/warning messages when not in development mode |
| src/util/logs-polling-utilities.ts | Implements withDeprecationsDisabled wrapper to suppress Apollo deprecation warnings during query execution |
| src/adapters/base-class.ts | Adds parseEnvVariablesString method for URL-safe parsing and converts string variableType to array for consistent handling |
| src/adapters/github.ts | Updates server command handling to conditionally include field only when non-empty after trimming |
| src/adapters/file-upload.ts | Mirrors github.ts server command handling improvements |
| src/commands/launch/index.ts | Enables multiple flag support for --variable-type and updates documentation |
| test/unit/util/apollo-client.test.ts | New test file covering console suppression behavior in development vs non-development environments |
| src/adapters/github.test.ts | Adds comprehensive tests for deployment flow and server command prompt scenarios |
| src/adapters/file-upload.test.ts | New test file mirroring github.test.ts coverage for file upload adapter |
| src/adapters/base-class.test.ts | Expands tests for variable type handling including string-to-array conversion and multiple option combinations |
| package.json | Updates @apollo/client to ^3.14.0, pins form-data to 4.0.4, adds overrides for axios and form-data |
| package-lock.json | Reflects dependency updates with axios 1.10.0 for nested packages and form-data 4.0.4 throughout |
| AGENTS.md | New file documenting testing conventions and guidelines for agent-assisted development |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chore: update version in package.json file
Update version in package.json file from 1.9.3 to 1.9.4
fb88241
chore: Update form-data to 4.0.4
fix: skip environment variables option with --variable-type flag
fix: suppress error message in non-development environments
fix: environment variable parsing for URL formatted values
fix: allow --variable-type flag to accept multiple values
fix: handle empty server command input properly