Skip to content

fix: doc type fixes #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: doc type fixes #53

merged 2 commits into from
Sep 27, 2024

Conversation

vkalta
Copy link
Contributor

@vkalta vkalta commented Sep 15, 2024

No description provided.

@vkalta vkalta requested a review from a team as a code owner September 15, 2024 09:57
@@ -201,7 +201,7 @@ export class Entries extends EntryQueryable {
* @example
* import contentstack from '@contentstack/delivery-sdk'
*
* const stack = contentstack.Stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
* const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
* const result = await stack.contentType('abc').entry().variant('xyz').find();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method called should be variants instead of variant

src/lib/query.ts Outdated
@@ -311,7 +311,7 @@ export class Query extends BaseQuery {
* @example
* import contentstack from '@contentstack/delivery-sdk'
*
* const stack = contentstack.Stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
* const stack = contentstack.stack({ apiKey: "apiKey", deliveryToken: "deliveryToken", environment: "environment" });
* const query1 = stack.contentType('contenttype_uid').Entry().query().containedIn('fieldUID', ['value']);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entry to be replaced with entry throughout the file

@vkalta vkalta requested a review from nadeem-cs September 18, 2024 08:25
Copy link
Contributor

@nadeem-cs nadeem-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@netrajpatel netrajpatel changed the base branch from next to development September 27, 2024 09:08
@netrajpatel netrajpatel merged commit d8a1480 into development Sep 27, 2024
5 checks passed
@netrajpatel netrajpatel deleted the fix/doctype_fixes branch September 27, 2024 09:09
cs-raj pushed a commit that referenced this pull request Nov 1, 2024
harshithad0703 pushed a commit that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants