Skip to content

Update .talismanrc #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged

Update .talismanrc #195

merged 1 commit into from
Jul 3, 2025

Conversation

harshithad0703
Copy link
Contributor

No description provided.

@harshithad0703 harshithad0703 requested a review from a team as a code owner July 3, 2025 07:12
@netrajpatel netrajpatel requested a review from Copilot July 3, 2025 07:15
@netrajpatel netrajpatel merged commit f4664a2 into development Jul 3, 2025
8 checks passed
@netrajpatel netrajpatel deleted the fix/update-talismanrc branch July 3, 2025 07:16
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Talisman configuration to add new files to the ignore list, ensuring that checksums for recently added tests and a type definition file don’t trigger Talisman failures.

  • Added test/unit/contentstack.spec.ts, test/unit/utils.spec.ts, test/unit/persistance/preference-store.spec.ts to fileignoreconfig
  • Added test/unit/contentstack.spec.ts and src/lib/types.ts entries for checksums
  • No version bump in .talismanrc (remains "1.0")
Comments suppressed due to low confidence (1)

.talismanrc:14

  • [nitpick] Double-check that excluding src/lib/types.ts is intentional, as ignoring a core type definition file may hide accidental commits of sensitive data in the future.
  - filename: src/lib/types.ts

@@ -7,4 +7,12 @@ fileignoreconfig:
checksum: 0f3457f8ea8b149c5de1d6585c78eb4cea0d2ac00ca69cdc294c44fe29ea3c11
- filename: test/api/live-preview.spec.ts
checksum: acdb1bd25dc81cfd9ea16e8a3e3960930c9e6e6034defd8552421e0d25e8afc4
- filename: test/unit/contentstack.spec.ts
Copy link
Preview

Copilot AI Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using glob patterns (e.g., test/unit/**/*.spec.ts) instead of listing each spec file individually to reduce maintenance as new tests are added.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants