Rename the Assets class Query method to makeQuery #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary due to how the Assets class inherits from BaseQuery. As both classes define a `query` and `Query` method these overlap. Unfortunately they do not have similar functionality - from what I see it seems that the Assets class uses the same Query method as the ContentType class. As Assets query method is most similar to ContentType’s method changing that method name could make sense. However to prevent more breaking changes, I think, this should be avoid. Plus I think there’s justification for different method names since they have slightly different contexts.
Author
Contributor
|
Hi @mallardduck , We fixed issue with Asset Query function in pull request #12 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary due to how the Assets class inherits from BaseQuery. As both classes define a
queryandQuerymethod these overlap. Unfortunately they do not have similar functionality - from what I see it seems that the Assets class uses the same Query method as the ContentType class.As Assets query method is most similar to ContentType’s method changing that method name could make sense. However to prevent more breaking changes, I think, this should be avoid. Plus I think there’s justification for different method names since they have slightly different contexts.