Skip to content

Refactor getCacheCallback to directly use parent promise's resolve an… #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunil-lakshman merged 3 commits into from
Jan 24, 2025
Merged

Refactor getCacheCallback to directly use parent promise's resolve an… #271

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a2aef1
Refactor getCacheCallback to directly use parent promise's resolve an…
sunil-lakshman Jan 23, 2025
b89e866
Updated utils.js file
sunil-lakshman Jan 23, 2025
7f7069a
Fixed empty object error when API throw error
sunil-lakshman Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions src/core/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,19 +252,20 @@ export function sendRequest(queryObject, options) {
}
}

let getCacheCallback = function() {
let getCacheCallback = function(resolve, reject) {
return function(err, entries) {
return new Promise(function(resolve, reject) {
try {
if (err) reject(err);
if (!tojson) entries = resultWrapper(entries);
resolve(spreadResult(entries));
} catch (e) {
reject(e)
try {
if (err) {
return reject(err); // Propagate the error to the parent promise
}
});
}
}
if (!tojson) entries = resultWrapper(entries);
resolve(spreadResult(entries)); // Propagate the result to the parent promise
} catch (e) {
reject(e); // Handle any synchronous errors
}
};
};


let callback = function(continueFlag, resolve, reject) {
if (continueFlag) {
Expand All @@ -291,7 +292,7 @@ export function sendRequest(queryObject, options) {
if (err || !_data || (_data.entries.length === 0 && _data.assets.length === 0)) {
return reject({ error_code: 141, error_message: 'The requested entry doesn\'t exist.' });
}
getCacheCallback()(err, _data);
getCacheCallback(resolve, reject)(err, _data);
});
return
} else {
Expand Down Expand Up @@ -339,11 +340,12 @@ export function sendRequest(queryObject, options) {
}.bind(self))
.catch(function(error) {
if (cachePolicy === 2 && self.provider !== null) {
self.provider.get(hashQuery, getCacheCallback());
self.provider.get(hashQuery, getCacheCallback(resolve, reject));
} else {
return reject(error);
reject(error);
}
});

}
}
switch (cachePolicy) {
Expand Down
Loading