Skip to content

Fix/added release workflow#7

Closed
abhinav-from-contentstack wants to merge 5 commits intomainfrom
fix/added_release_workflow
Closed

Fix/added release workflow#7
abhinav-from-contentstack wants to merge 5 commits intomainfrom
fix/added_release_workflow

Conversation

@abhinav-from-contentstack
Copy link
Contributor

@abhinav-from-contentstack abhinav-from-contentstack commented Feb 2, 2023

current version : 1.0.7

This PR adds a release workflow, LICENSE updates and a newline at the end of a typings file (to address an eslint error in one of the workflows).

There are no major changes to the code. Hence the package version need not be updated.

@netrajpatel
Copy link

@abhinav-from-contentstack
The GitHub workflow is failing, can you fix that?

@netrajpatel
Copy link

@abhinav-from-contentstack This workflow is failing, please fix this.

@abhinav-from-contentstack
Copy link
Contributor Author

@netrajpatel Are you referring to the node.js CI workflow?

It was added by the author of this repository. It tries to build the package using old versions of node, and then runs the test cases. I've never seen it run successfully yet.

Should I fix this?

@netrajpatel
Copy link

@netrajpatel Are you referring to the node.js CI workflow?

It was added by the author of this repository. It tries to build the package using old versions of node, and then runs the test cases. I've never seen it run successfully yet.

Should I fix this?

Yes please fix this as well.

Copy link

@netrajpatel netrajpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhinav-from-contentstack
Please add a note for the plugin version update

@abhinav-from-contentstack
Copy link
Contributor Author

@netrajpatel done

@aman19K
Copy link
Contributor

aman19K commented Jul 5, 2023

Handled in PR #9

@aman19K aman19K closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants