dx | 1169 getter methods implementation #1522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
harshithad0703
commented
Aug 20, 2024
harshithad0703
commented
- implemented getter methods for developer hub, launch and personalize
- replaced getDeveloperHubUrl method with getter method in export and import plugin
- replaced getLaunchHubUrl method with getter method in launch plugin
- @contentstack/cli-cm-export: 1.11.6 -> 1.12.0
- @contentstack/cli-cm-import: 1.16.5 -> 1.17.0
- @contentstack/cli-command: 1.2.19 -> 1.3.0
- @contentstack/cli-launch: 1.2.0 -> 1.3.0
shafeeqd959
reviewed
Aug 21, 2024
packages/contentstack-export/src/export/modules-js/marketplace-apps.js
Outdated
Show resolved
Hide resolved
packages/contentstack-export/src/export/modules/marketplace-apps.ts
Outdated
Show resolved
Hide resolved
packages/contentstack-import/src/import/modules/marketplace-apps.ts
Outdated
Show resolved
Hide resolved
Contributor
|
@harshithad0703 , since we're only maintaining TS One, there's no need to modify the export and import JS code. |
aman19K
reviewed
Aug 21, 2024
aman19K
previously approved these changes
Aug 21, 2024
aman19K
approved these changes
Aug 21, 2024
sunil-lakshman
pushed a commit
that referenced
this pull request
Oct 22, 2024
dx | 1169 getter methods implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.