fix: handle case where CT is missing from mapping for given variable [SPA-2923] #1353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SofiaMargariti
requested review from
Spring3 and
jshmo
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
SofiaMargariti
changed the title
SofiaMargariti
commented
Sep 26, 2025
|
|
||
| it('should return undefined when variableMapping does not have info for contentType used with default value', () => { | ||
| const localEntityStore = createEntityStoreWithComponentSettings({ | ||
| entitiesOverrides: [ |
There was a problem hiding this comment.
was returning undefined because the entity was missing, not for the scenario the test is aiming to check
Ollie-H
approved these changes
Sep 29, 2025
This was referenced Sep 30, 2025
Merged
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes: #1326 (comment)
Approach