Conversation
dborsatto
reviewed
May 2, 2018
dborsatto
left a comment
dborsatto
left a comment
There was a problem hiding this comment.
How do you handle entries or assets built using different locales?
In the PHP SDK I use a similar mechanism where I keep objects in memory, but for entries and assets the cache keys contain the locale as well (it's something like Asset-5rk09fujeeoiw-en-US).
If I don't use the locale as part of the cache key I might end up with possible conflicts, due to assets/entries being fetched from the cache having a different locale (or no locale at all) from the one you're currently using. I suspect you might have the same issue here, but you probably can just solve it by changing cache_key in resource.py#45 🙂
Contributor
Author
|
Hmm, this is interesting, I could make it locale aware. I'll take a look into it. |
dborsatto
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by contentful/contentful.rb#164