Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove function-templates example [EXT-6286] #9607

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

whitelisab
Copy link
Contributor

@whitelisab whitelisab commented Mar 26, 2025

Purpose

We have already moved the function-templates and renamed it to external-references. This PR removes the function-template directory.

Approach

All function examples that have the TS/JS subdirectories and are created by merging with one of the frontend templates, and they have been moved into the function-examples directory. We already moved the code from this function-templates directory into the function-examples/external-references directory, so this PR just removes the old directory.

You can still bootstrap this example with the CCA using the command: npx create-contentful-app@latest --function external-references

Also removed function-template from CODEOWNERS and the dependabot.yml file.

Testing steps

Breaking Changes

Dependencies and/or References

Deployment

@whitelisab whitelisab requested review from a team as code owners March 26, 2025 22:46
@whitelisab whitelisab requested a review from a team March 26, 2025 22:47
Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for ecommerce-app-base-components canceled.

Name Link
🔨 Latest commit cc75248
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-app-base-components/deploys/67e559de9cce6500085c830a

BasKiers
BasKiers approved these changes Mar 27, 2025
@whitelisab whitelisab force-pushed the fix/ext-6286-remove-function-templates branch from 2587829 to cc75248 Compare March 27, 2025 13:59
@whitelisab whitelisab merged commit bac30c0 into master Mar 27, 2025
17 checks passed
@whitelisab whitelisab deleted the fix/ext-6286-remove-function-templates branch March 27, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants