Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update app event filter example to be a single frontendless app [EXT-6286] #9602

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

whitelisab
Copy link
Contributor

Purpose

Since creating the new function templates, some of our function examples were not working properly due to the sub-directory setup. This PR changes the App Event Filter Function example to be a single frontendless app example that can be bootstrapped via the CCA using npx create-contentful-app@latest --example function-appevent-filter.

Approach

Here is a summary of the changes:

  • Removed the TS/JS sub-directories in favor of a singular app example
  • This example has no frontend; the only code is for functions and some setup scripts
  • Add more details to the INSTRUCTIONS file, including how to use the scripts to easily get setup
  • Added a script for creating an app event subscription that links to the filter function and a script to create a content type with the correct fields and publish two entries of differing sentiment
  • Bumped @contentful/node-apps-toolkit and use the FunctionTypeEnum

Testing steps

I tested this app locally and also via the CCA by pointing the local CCA to this branch. I ran through all the scripts in the instructions to ensure that they work properly.

Breaking Changes

Dependencies and/or References

Deployment

@whitelisab whitelisab requested a review from a team as a code owner March 25, 2025 17:10
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for ecommerce-app-base-components canceled.

Name Link
🔨 Latest commit c06deef
🔍 Latest deploy log https://app.netlify.com/sites/ecommerce-app-base-components/deploys/67e2e388c88109000855c26d

@whitelisab whitelisab requested a review from a team March 25, 2025 17:10
Copy link
Contributor

@michaelpineirocontentful michaelpineirocontentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@whitelisab whitelisab merged commit 7714b4e into master Mar 25, 2025
17 checks passed
@whitelisab whitelisab deleted the fix/ext-6286-func-examples branch March 25, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants