fix: ISSUE-967: Remove the RST0..=RST7 check from the has_length method for the JPEG asset handler.
#968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brogdonm
changed the title
RST0..=RST7 check from the has_length method.RST0..=RST7 check from the has_length method.
brogdonm
changed the title
RST0..=RST7 check from the has_length method.RST0..=RST7 check from the has_length method for the JPEG asset handler.
mauricefisher64
requested review from
mauricefisher64 and
scouten-adobe
and removed request for
scouten-adobe
mauricefisher64
approved these changes
Mar 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Give a narrative description of what has been changed.
As #967 states, this removes the ReSTart 0 through 7 segment markers from the
has_lengthcheck. As these markers are standalone markers and do not have a 2-byte length specified after them.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.