Skip to content

Conversation

@mauricefisher64
Copy link
Collaborator

Changes in this pull request

The default signers were not returning the correct reserve size

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

…1-c2patool-0111---fragment---fragments_glob-fmp4-signing-broken
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 30.76923% with 27 lines in your changes missing coverage. Please review.

Project coverage is 78.83%. Comparing base (9428dc7) to head (936b765).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/raw_signature/openssl/signers/ed25519_signer.rs 0.00% 12 Missing ⚠️
...to/src/raw_signature/openssl/signers/rsa_signer.rs 0.00% 12 Missing ⚠️
.../src/raw_signature/openssl/signers/ecdsa_signer.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   78.85%   78.83%   -0.02%     
==========================================
  Files         146      146              
  Lines       35213    35229      +16     
==========================================
+ Hits        27766    27773       +7     
- Misses       7447     7456       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mauricefisher64 mauricefisher64 merged commit cb965f7 into main Mar 12, 2025
29 of 31 checks passed
@mauricefisher64 mauricefisher64 deleted the 871-c2patool-0111---fragment---fragments_glob-fmp4-signing-broken branch March 12, 2025 19:27
@scouten-adobe scouten-adobe mentioned this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted bug Something isn't working status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

c2patool 0.11.1 - fragment --fragments_glob / fmp4 signing broken

3 participants