Skip to content

Conversation

@scouten-adobe
Copy link
Collaborator

No description provided.

@scouten-adobe scouten-adobe self-assigned this Mar 10, 2025
@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (7bfc9b0) to head (17edfce).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   78.80%   78.78%   -0.02%     
==========================================
  Files         146      146              
  Lines       35096    35096              
==========================================
- Hits        27657    27652       -5     
- Misses       7439     7444       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scouten-adobe
Copy link
Collaborator Author

@cdmurph32 would you please add instructions on building using upstream llvm vs Xcode on Mac?

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@cdmurph32
Copy link
Collaborator

cdmurph32 commented Mar 10, 2025

We might need to document the need inability to use XCode clang for wasm. This was already true for WASI, but that was more recently added.
For Mac silicon:

  1. brew install llvm
  2. In project root: ./cargo/config.toml
[env]
CC = "/opt/homebrew/opt/llvm/bin/clang"

[target.wasm32-wasip2]
runner = "wasmtime -S cli -S http --dir ."

wasmtime is only necessary for running WASI tests, but that documentation would probably live in the same place.

@gpeacock
Copy link
Collaborator

We will need to update the build servers to have llvm installed, but maybe they already do for wasi??

@cdmurph32
Copy link
Collaborator

We will need to update the build servers to have llvm installed, but maybe they already do for wasi??

No need. The build servers use ubuntu for wasm builds.

@gpeacock gpeacock merged commit bd6c119 into main Mar 11, 2025
30 of 31 checks passed
@gpeacock gpeacock deleted the update-x509-cert-and-ring branch March 11, 2025 03:35
This was referenced Mar 11, 2025
This was referenced Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants