Skip to content

Conversation

@cdmurph32
Copy link
Collaborator

Changes in this pull request

Add sync trait to AsyncDynamicAssertion
Required for V24 node SDK.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (faf5a02) to head (1de02bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   78.80%   78.78%   -0.02%     
==========================================
  Files         146      146              
  Lines       35096    35096              
==========================================
- Hits        27657    27652       -5     
- Misses       7439     7444       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe changed the title feat: Add sync to async dynamic assertion. feat: Add Sync to AsyncDynamicAssertion Mar 4, 2025
@cdmurph32 cdmurph32 merged commit 7bfc9b0 into main Mar 5, 2025
32 of 33 checks passed
@cdmurph32 cdmurph32 deleted the dynamic_assertion_add_sync branch March 5, 2025 00:31
@scouten-adobe scouten-adobe mentioned this pull request Feb 28, 2025
This was referenced Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants