Skip to content

Conversation

@gpeacock
Copy link
Collaborator

@gpeacock gpeacock commented Feb 14, 2025

This allows DynamicAssertions to create JSON formatted assertions. Previously only Cbor formatted assertions were supported.

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.91%. Comparing base (1cda7bd) to head (750a2fa).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/store.rs 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
- Coverage   78.91%   78.91%   -0.01%     
==========================================
  Files         147      147              
  Lines       34805    34819      +14     
==========================================
+ Hits        27466    27476      +10     
- Misses       7339     7343       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change requested (see earlier comment); otherwise 👍

@gpeacock gpeacock merged commit 89ae3c0 into main Feb 15, 2025
30 checks passed
@gpeacock gpeacock deleted the gpeacock/dynamic_json_assertions branch February 15, 2025 00:16
This was referenced Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants