fix: Restore support for claim_generator_hints. #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add claim URI or Ingredient URI when possible
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
==========================================
- Coverage 78.81% 78.80% -0.02%
==========================================
Files 146 146
Lines 34646 34648 +2
==========================================
- Hits 27307 27305 -2
- Misses 7339 7343 +4 ☔ View full report in Codecov by Sentry. |
andrewhalle
approved these changes
Feb 10, 2025
gpeacock
reviewed
Feb 10, 2025
|
We had a sample from a customer and we support other 1.0 features |
gpeacock
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Why support this? No one ever implemented it and it wasn't written to any claims. It was briefly in the spec, but removed quickly. Was there some test case that caused this to show up as an error?
I guess it makes sense at this level to not call it an error, but we won't let you produce the field at the upper later or show it in our reports.
|
Makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Support for 1.0 Claim claim_generator_hints field that was inadvertently removed.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.