Skip to content

Conversation

@mauricefisher64
Copy link
Collaborator

Changes in this pull request

Remove redundant wrapped error codes.
Initial support for new error and status code
Better reporting with correct URIs for Ingredients

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 51.37615% with 53 lines in your changes missing coverage. Please review.

Project coverage is 78.81%. Comparing base (4cb20e3) to head (e105c62).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/claim.rs 47.52% 53 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   78.97%   78.81%   -0.17%     
==========================================
  Files         146      146              
  Lines       34555    34646      +91     
==========================================
+ Hits        27291    27307      +16     
- Misses       7264     7339      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scouten-adobe scouten-adobe changed the title fix: Update error reporting. fix: Update error reporting Feb 6, 2025
Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick clarification; otherwise 👍.

@mauricefisher64 mauricefisher64 merged commit 4ac5354 into main Feb 6, 2025
28 of 30 checks passed
@mauricefisher64 mauricefisher64 deleted the error_report branch February 6, 2025 20:22
@scouten-adobe scouten-adobe mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants