Skip to content

Conversation

@mauricefisher64
Copy link
Collaborator

Complete rust native support
Fix broken certificate dump
Support arbitrary curves for EC signatures

Changes in this pull request

Give a narrative description of what has been changed.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

Complete rust native support
Fix broken certificate dump
Support arbitrary curves for EC signatures
@codecov
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 77.57256% with 85 lines in your changes missing coverage. Please review.

Project coverage is 78.99%. Comparing base (56bea2f) to head (3966390).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...to/src/raw_signature/rust_native/validators/mod.rs 54.34% 21 Missing ⚠️
internal/crypto/src/cose/sign.rs 11.11% 16 Missing ⚠️
...crypto/src/raw_signature/openssl/validators/mod.rs 34.78% 15 Missing ⚠️
...w_signature/rust_native/check_certificate_trust.rs 78.68% 13 Missing ⚠️
internal/crypto/src/ec_utils.rs 87.50% 11 Missing ⚠️
internal/crypto/src/cose/verifier.rs 78.78% 7 Missing ⚠️
internal/crypto/src/cose/certificate_profile.rs 50.00% 1 Missing ⚠️
.../src/raw_signature/openssl/signers/ecdsa_signer.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   79.14%   78.99%   -0.15%     
==========================================
  Files         144      146       +2     
  Lines       34172    34547     +375     
==========================================
+ Hits        27045    27291     +246     
- Misses       7127     7256     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge until I've had a chance to make edits and to restore the WASM platform tests. ETA 20-30 minutes. Good to go!

Copy link
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot. I just forgot that I was going to update the README. Please hold until I do that.

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should add a description field to Action. We never had it there before. The test case was wrong. I'm not sure how we ever generated it.

@scouten-adobe scouten-adobe merged commit 6236c66 into main Jan 31, 2025
28 of 30 checks passed
@scouten-adobe scouten-adobe deleted the crpto_updates branch January 31, 2025 18:55
@scouten-adobe scouten-adobe mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants