-
Couldn't load subscription status.
- Fork 100
fix: Remove dependency on SubtleCrypto #881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Complete rust native support Fix broken certificate dump Support arbitrary curves for EC signatures
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #881 +/- ##
==========================================
- Coverage 79.14% 78.99% -0.15%
==========================================
Files 144 146 +2
Lines 34172 34547 +375
==========================================
+ Hits 27045 27291 +246
- Misses 7127 7256 +129 ☔ View full report in Codecov by Sentry. |
internal/crypto/src/tests/raw_signature/rust_native/validators.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not merge until I've had a chance to make edits and to restore the WASM platform tests. ETA 20-30 minutes. Good to go!
…into crpto_updates
… crpto_updates # Conflicts: # internal/crypto/src/ec_utils.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot. I just forgot that I was going to update the README. Please hold until I do that.
…into crpto_updates # Conflicts: # internal/crypto/README.md
Cleanup/simplification of crypto selection paths
Remove unused overly restrictive cert check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should add a description field to Action. We never had it there before. The test case was wrong. I'm not sure how we ever generated it.
Complete rust native support
Fix broken certificate dump
Support arbitrary curves for EC signatures
Changes in this pull request
Give a narrative description of what has been changed.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.