(MINOR) Introduce a new SigningAlg enum
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce UnknownAlgorithmError for when "string".parse() as SigningAlg fails.
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 74.12% 74.49% +0.36%
==========================================
Files 65 66 +1
Lines 13454 13471 +17
==========================================
+ Hits 9973 10035 +62
+ Misses 3481 3436 -45
Continue to review full report at Codecov.
|
gpeacock
reviewed
Jul 15, 2022
gpeacock
approved these changes
Jul 15, 2022
# Conflicts: # sdk/src/cose_sign.rs # sdk/src/cose_validator.rs # sdk/src/wasm/webcrypto_validator.rs
mauricefisher64
added a commit
that referenced
this pull request
Jul 19, 2022
…ync_sign * 'main' of https://github.com/contentauth/c2pa-rs: Prepare 0.9.0 release (MINOR) Introduce a new `SigningAlg` enum (#76) Support for asynchronous signing of claims (#57) # Conflicts: # sdk/src/cose_sign.rs # sdk/src/cose_validator.rs # sdk/src/openssl/temp_signer_async.rs # sdk/src/signer.rs # sdk/src/store.rs
mauricefisher64
added a commit
that referenced
this pull request
Jul 20, 2022
…timize * 'main' of https://github.com/contentauth/c2pa-rs: (MINOR) `IngredientOptions` allow override of hash and thumbnail generation; image library is now a default feature (#79) Prepare 0.9.1 release Fix publish workflow (#82) Prepare 0.9.0 release (MINOR) Introduce a new `SigningAlg` enum (#76) # Conflicts: # sdk/src/ingredient.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
This PR replaces almost all instances of the
&strparameters that identify signing algorithms ("ps256", etc.) with a newSigningAlgenum and pushes any conversion to/from the existing string identifiers to a relatively few API edges.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.