Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements embed_reference_to_stream for jpeg #430

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

gpeacock
Copy link
Collaborator

This works without xmp_toolkit

This works without xmp_toolkit
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.91%. Comparing base (cde7927) to head (7fbfb05).

Files Patch % Lines
sdk/src/asset_handlers/jpeg_io.rs 93.02% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   79.87%   79.91%   +0.03%     
==========================================
  Files          82       82              
  Lines       25493    25532      +39     
==========================================
+ Hits        20362    20403      +41     
+ Misses       5131     5129       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdk/src/asset_handlers/jpeg_io.rs Outdated Show resolved Hide resolved
sdk/src/asset_handlers/jpeg_io.rs Show resolved Hide resolved
sdk/src/asset_handlers/jpeg_io.rs Outdated Show resolved Hide resolved
@gpeacock gpeacock requested a review from dkozma March 25, 2024 20:37
Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mauricefisher64 mauricefisher64 merged commit b3e85c7 into main Mar 27, 2024
22 checks passed
@mauricefisher64 mauricefisher64 deleted the jpeg_xmp_to_stream branch March 27, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants