Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trust support #415

Merged
merged 66 commits into from
Mar 8, 2024
Merged

Trust support #415

merged 66 commits into from
Mar 8, 2024

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

This PR brings the trust support features to the SDK. It also ties in configuration settings to control the behavior. Default behavior mimics the current SDK, i.e.

  • no trust checking by default
  • no ocsp fetching by default
  • check signature after signing by default

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

mauricefisher64 and others added 30 commits December 4, 2023 17:23
@mauricefisher64
Push to keep things moving
de36981
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into tr…
3e0e26c 
…ust_support

# Conflicts:
#	sdk/Cargo.toml
#	sdk/src/cose_sign.rs
#	sdk/src/cose_validator.rs
@gpeacock
Add ManifestStoreOptions to async bytes functions
872c4fc 
ManifestStore::from_bytes_async()
ManifestStore::from_manifest_and_asset_bytes_async
Also some fmt/clippy fixes
Builds but unit tests do not run yet
@mauricefisher64
WASM build
4123156
@mauricefisher64
Merge branch 'trust_support' of https://github.com/contentauth/c2pa-rs …
933ae49 
…into trust_support

# Conflicts:
#	sdk/src/cose_validator.rs
#	sdk/src/trust_handler.rs
#	sdk/src/wasm/webpki_trust_handler.rs
@mauricefisher64
WASM fix
5166834
Expose ManifestStoreOptions
f84b3dc
@mauricefisher64
Fix missing anchors
b7bbfed
@mauricefisher64
Merge branch 'trust_support' of https://github.com/contentauth/c2pa-rs …
b7b791e 
…into trust_support
@mauricefisher64
Fix misspelled var
d1404d1
@mauricefisher64
remove check that may be wrong
69013f6
@mauricefisher64
remove issuer check
d11cb34
@mauricefisher64
switch to x509_parser because x509-certificate has issues
76f4daa
@mauricefisher64
Add support DER encoded EC signatures when validating trust lists
010af9f
@mauricefisher64
Update Adobe trust root
39e2b15
Small fixes for Wasm building (#354)
52aeb42
@mauricefisher64
Remove trust anchors from build, only leave the test certs
7c73ebe
@gpeacock
Add ManifestStore::from_file_with_options
e872f6f
@gpeacock
Merge branch 'trust_support' of https://github.com/contentauth/c2pa-rs …
52de39d 
…into trust_support
@mauricefisher64
Minor fixes
d9b4286
@mauricefisher64
Merge branch 'trust_support' of https://github.com/contentauth/c2pa-rs …
33763e2 
…into trust_support
@mauricefisher64
Trust fixes
cced3e0
Wasm compiler fixes
a568870
@mauricefisher64
Restored more tests
25c9c31
@mauricefisher64
EC sig fix
dee1aeb
@mauricefisher64
Add ARW & NEF support
7e496e5
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into tr…
290c44f 
…ust_support
@mauricefisher64
Fix for wrong sig algoritm
ff65f35
@mauricefisher64
Support for allowed list
cf7e4dc
Add Wasm compilation fixes for trust_support branch (#401)
ae01dc5
gpeacock
gpeacock reviewed Feb 29, 2024
View reviewed changes
sdk/src/lib.rs Outdated Show resolved Hide resolved
gpeacock
gpeacock approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggested changes and some questions.
I'd really rather not publish the extended ManifestStoreOptions interface instead of Settings. I don't understand why we need this. Is Settings not ready enough?

sdk/src/manifest_store.rs Outdated Show resolved Hide resolved
sdk/src/claim.rs Show resolved Hide resolved
sdk/src/cose_validator.rs Outdated Show resolved Hide resolved
sdk/src/cose_validator.rs Outdated Show resolved Hide resolved
sdk/src/cose_validator.rs Show resolved Hide resolved
sdk/src/manifest_store.rs Outdated Show resolved Hide resolved
sdk/src/store.rs Show resolved Hide resolved
sdk/tests/integration.rs Show resolved Hide resolved
@mauricefisher64
Remove ManifestStore changes
d721ac7 
Update integration example to use loading settings from JSON
@mauricefisher64 mauricefisher64 changed the title (MINOR) Trust support Trust support Mar 1, 2024
@mauricefisher64
Change more feature flags
da7cd27
@mauricefisher64
enhance trust pass through to support configuration of allowed_list a…
3427ca9 
…nd EKU config

Check signing cert before signing so that it gets checked independent of whether we validate after signing
@mauricefisher64
A little code cleanup
8e2e5b6
@mauricefisher64
Make sure ED25519 tests are disabled for WASM
6b54f6d
@mauricefisher64
Remove Ed25519 from trust list until we can get it working in WASM
c6362f1
@mauricefisher64
Enable Ed25519 support
50cf65b
@mauricefisher64
Added debug logging for ed25519
7cadfcc
@mauricefisher64
wasm build fix
65133e0
@mauricefisher64
fix broken check
e4d4d9a
@mauricefisher64
Fixes for wasm
42813fb
@mauricefisher64
Fix build failure
77a724e
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into tr…
c450bb1 
…ust_support
@mauricefisher64
Fix comment
cf8be1f
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into tr…
3ec11fd 
…ust_support
@mauricefisher64
Code cleanup
2f3b6c7
@mauricefisher64
Merge branch 'main' of https://github.com/contentauth/c2pa-rs into tr…
0ec7b2e 
…ust_support
@mauricefisher64
OCSP fix
523a98a
@mauricefisher64 mauricefisher64 merged commit ca88432 into main Mar 8, 2024
22 checks passed
@mauricefisher64 mauricefisher64 deleted the trust_support branch March 8, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkozma dkozma Awaiting requested review from dkozma

@gpeacock gpeacock Awaiting requested review from gpeacock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mauricefisher64 @codecov-commenter @gpeacock