Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box hash support #261

Merged
merged 12 commits into from
Jun 9, 2023
Merged

Box hash support #261

merged 12 commits into from
Jun 9, 2023

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

Support for C2PA 1.3 box hashing. Only available for JPEG and PNG.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Merging #261 (ecd86a4) into main (b29cc1c) will increase coverage by 0.17%.
The diff coverage is 82.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   77.67%   77.85%   +0.17%     
==========================================
  Files          74       75       +1     
  Lines       20972    21700     +728     
==========================================
+ Hits        16291    16895     +604     
- Misses       4681     4805     +124     
Impacted Files Coverage Δ
sdk/src/assertions/labels.rs 82.60% <ø> (ø)
sdk/src/asset_io.rs 54.28% <0.00%> (-5.09%) ⬇️
sdk/src/claim.rs 81.39% <27.58%> (-3.56%) ⬇️
sdk/src/assertions/bmff_hash.rs 19.85% <66.66%> (ø)
sdk/src/asset_handlers/png_io.rs 93.26% <76.74%> (-1.33%) ⬇️
sdk/src/store.rs 87.11% <84.13%> (-0.27%) ⬇️
sdk/src/asset_handlers/jpeg_io.rs 91.78% <90.86%> (-0.41%) ⬇️
sdk/src/assertions/box_hash.rs 91.74% <91.74%> (ø)
sdk/src/assertions/data_hash.rs 84.68% <100.00%> (ø)
sdk/src/ingredient.rs 84.33% <100.00%> (ø)
... and 3 more

Copy link
Contributor

@brogdonm brogdonm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mauricefisher64 thanks for this work, I was going through here to understand how it was implemented. I have a few questions in areas I'm unsure of. If I'm totally off base, please ignore. ;)

sdk/src/assertions/box_hash.rs Show resolved Hide resolved
sdk/src/assertions/box_hash.rs Show resolved Hide resolved
sdk/src/assertions/box_hash.rs Show resolved Hide resolved
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some questions about how this works

sdk/src/assertions/data_hash.rs Show resolved Hide resolved
sdk/src/asset_handlers/jpeg_io.rs Show resolved Hide resolved
sdk/src/asset_handlers/jpeg_io.rs Show resolved Hide resolved
sdk/src/manifest_store.rs Show resolved Hide resolved
sdk/src/asset_handlers/jpeg_io.rs Show resolved Hide resolved
sdk/src/asset_handlers/jpeg_io.rs Show resolved Hide resolved
@mauricefisher64 mauricefisher64 merged commit 50e7005 into main Jun 9, 2023
@mauricefisher64 mauricefisher64 deleted the box_hash branch June 9, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants