Fix async path to support ingredient box hashing #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 78.41% 78.37% -0.04%
==========================================
Files 69 69
Lines 16889 16897 +8
==========================================
Hits 13243 13243
- Misses 3646 3654 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dkozma
pushed a commit
that referenced
this pull request
Mar 9, 2023
Fix asyn path to support ingredient box hashing
gpeacock
added a commit
that referenced
this pull request
Mar 17, 2023
* replaces file implementation with stream implementation * remove extraneous allow * First sign_only push * adds tests * adds write_cai test * makes tests more stream like * In memory writing writing support * add ingredient::from_stream and from_memory Note: doesn't validate yet: * adds png as valid caiwriter * improves write_cai tests * Add validation and thumb generation * simplifies file opening for tests * new streaming write apis * Remove check until we can figure out how to make this work for all cases * JPEG writing in WASM suppport * Return manifest and asset * Disable part of test until we expose APIs to WASM * Update RemoteSigner for Wasm compatibility (#193) * Update RemoteSigner for Wasm compatibility * Fix async path to support ingredient box hashing (#201) Fix asyn path to support ingredient box hashing * Fix hash algo warning in Wasm and hashing for RSA-PSS SHA-384/512 * Support for XMP streaming write and removing manifest from streams --------- Co-authored-by: Gavin Peacock <gpeacock@adobe.com> Co-authored-by: Dylan ross <dylan.ssor@gmail.com> Co-authored-by: Eric Scouten <scouten@adobe.com> Co-authored-by: Dave Kozma <dkozma@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Update the asyn ingredient check to test for ingredient box hashes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.