Skip to content

Conversation

@mauricefisher64
Copy link
Collaborator

Changes in this pull request

Updates to tweaks to hash binding logging
Fix accidentally removed unknown ingredient status
Better update manifest handling

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 63.22751% with 139 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.28%. Comparing base (157f247) to head (ff38852).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
sdk/src/claim.rs 60.48% 113 Missing ⚠️
sdk/src/store.rs 70.11% 26 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
- Coverage   78.30%   78.28%   -0.03%     
==========================================
  Files         153      153              
  Lines       39106    39157      +51     
==========================================
+ Hits        30622    30653      +31     
- Misses       8484     8504      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, there's a few places where we should be logging uris instead of labels.

@mauricefisher64 mauricefisher64 merged commit d45fdd8 into main Aug 14, 2025
21 of 23 checks passed
@mauricefisher64 mauricefisher64 deleted the hash_updates branch August 14, 2025 16:43
@caiopensrc caiopensrc mentioned this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants